Skip to content

Revert "Revert "RATIS-672. Vagrant test's Maven 404's""#223

Closed
Parigyan wants to merge 0 commit intoapache:masterfrom
Parigyan:master
Closed

Revert "Revert "RATIS-672. Vagrant test's Maven 404's""#223
Parigyan wants to merge 0 commit intoapache:masterfrom
Parigyan:master

Conversation

@Parigyan
Copy link
Copy Markdown

This reverts commit 89abd13

What changes were proposed in this pull request?

./dev-support/vagrant/run_all_tests.sh build command was failing.
There was previous patch available for the legacy issue , concerning Maven 404 response from apache mirror for maven installation.
The fix has to do with reverting the patch to original fix, and merging the new changes with the concerned files.

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/RATIS-672

How was this patch tested?

$./dev-support/vagrant/run_all_tests.sh build , command ran successfully
Screenshot 2020-10-13 at 11 57 46 PM

Copy link
Copy Markdown
Contributor

@lokeshj1703 lokeshj1703 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Parigyan Thanks for working on this!
./dev-support/vagrant/run_all_tests.sh build completed successfully for me.

Copy link
Copy Markdown
Contributor

@lokeshj1703 lokeshj1703 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Parigyan I was going through the commit messages for the reason why RATIS-672 was reverted.
It appears that docker build is failing with the PR. Can you please take a look?
./dev-support/docker Try building the Dockerfile in this folder for reproducing the issue.

@lokeshj1703 lokeshj1703 self-requested a review October 28, 2020 09:27
@lokeshj1703
Copy link
Copy Markdown
Contributor

The new Dockerfile would always require some arguments I guess. Can we give some default values to the ARG defined in the Dockerfile?

@Parigyan
Copy link
Copy Markdown
Author

@lokeshj1703 Thanks for the feedback, I'll take a look into dockerfile build.

@Parigyan
Copy link
Copy Markdown
Author

Parigyan commented Oct 28, 2020

Found https://yetus.apache.org/documentation/0.12.0/RELEASENOTES/
YETUS-919 was specifically created to address the issue of build failure in YETUS for docker args resolution vis-a-vis ratis.

add_docker_build_arg should get the work done.
In Dockerfile the argument for protobuf is already there, and it picks the value from source /dev-support/ci/common.sh
but it seems in case of yetus it fails as the common.sh is not sufficient in getting executed.

I'll try to use the new mechanism of passing the args for docker build in yetus.

@Parigyan Parigyan closed this Jan 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants