RATIS-1331. Make GrpcTLS config truststore param list.#436
Merged
mukul1987 merged 4 commits intoapache:masterfrom Mar 9, 2021
Merged
RATIS-1331. Make GrpcTLS config truststore param list.#436mukul1987 merged 4 commits intoapache:masterfrom
mukul1987 merged 4 commits intoapache:masterfrom
Conversation
Contributor
Author
|
cc @xiaoyuyao / @bshashikant for review. |
adoroszlai
reviewed
Mar 8, 2021
| X509Certificate trustStore, boolean mTlsEnabled) { | ||
| this.privateKey = privateKey; | ||
| this.certChain = certChain; | ||
| this.trustStore = Arrays.asList(trustStore); |
Contributor
There was a problem hiding this comment.
Suggestion: use Collections.singletonList instead of Arrays.asList.
symious
pushed a commit
to symious/ratis
that referenced
this pull request
Feb 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This Jira is to make truststore param a list of trusted CA certificate.
This will be needed for SCM HA.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/RATIS-1331
How was this patch tested?