RATIS-1361. Connection errors in Netty-based tests#463
Closed
adoroszlai wants to merge 9 commits intoapache:masterfrom
Closed
RATIS-1361. Connection errors in Netty-based tests#463adoroszlai wants to merge 9 commits intoapache:masterfrom
adoroszlai wants to merge 9 commits intoapache:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Few Netty-based tests started failing recently in CI with errors like:
without any code change. First failed on
masterfor a simple version number update.Also:
https://github.com/apache/ratis/runs/2379889361#step:5:4
https://github.com/apache/ratis/runs/2368524547?check_suite_focus=true#step:5:4
https://github.com/apache/ratis/runs/2379594469?check_suite_focus=true#step:5:4
They pass locally.
This PR attempts to fix these by resolving the "any local address" (0.0.0.0) specifically to the loopback address in the mini cluster.
https://issues.apache.org/jira/browse/RATIS-1359
How was this patch tested?
The same set of tests passed 5x repeatedly:
https://github.com/adoroszlai/incubator-ratis/runs/2384632003#step:5:1
https://github.com/adoroszlai/incubator-ratis/runs/2388377845#step:5:1
https://github.com/adoroszlai/incubator-ratis/runs/2388513282#step:5:1
https://github.com/adoroszlai/incubator-ratis/runs/2388574384#step:5:1
https://github.com/adoroszlai/incubator-ratis/runs/2388605600#step:5:1