Skip to content

RATIS-1467. Remove unused log4j dependency from pom.xml.#562

Merged
szetszwo merged 1 commit intoapache:masterfrom
szetszwo:RATIS-1467
Dec 13, 2021
Merged

RATIS-1467. Remove unused log4j dependency from pom.xml.#562
szetszwo merged 1 commit intoapache:masterfrom
szetszwo:RATIS-1467

Conversation

@szetszwo
Copy link
Contributor

@szetszwo szetszwo requested a review from adoroszlai December 12, 2021 11:42
Copy link
Contributor

@adoroszlai adoroszlai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dependency change looks good.

Note that ratis-hadoop has transitive dependency on log4j (via hadoop-common). I guess that's OK.

Should we also remove the log4j-related info below?

<supplement>
<project>
<groupId>log4j</groupId>
<artifactId>log4j</artifactId>
<licenses>
<license>
<name>Apache License, Version 2.0</name>
<url>http://www.apache.org/licenses/LICENSE-2.0.txt</url>
<distribution>repo</distribution>
</license>
</licenses>
</project>
</supplement>

@szetszwo
Copy link
Contributor Author

Should we also remove the log4j-related info below?

Let's keep the license in supplemental-models.xml, which includes licenses for transitive dependencies.

@szetszwo szetszwo merged commit 96b5c92 into apache:master Dec 13, 2021
@szetszwo
Copy link
Contributor Author

@adoroszlai , thanks a lot for reviewing this.

symious pushed a commit to symious/ratis that referenced this pull request Feb 27, 2024
@szetszwo szetszwo deleted the RATIS-1467 branch January 12, 2025 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants