RATIS-1467. Remove unused log4j dependency from pom.xml.#562
Merged
szetszwo merged 1 commit intoapache:masterfrom Dec 13, 2021
Merged
RATIS-1467. Remove unused log4j dependency from pom.xml.#562szetszwo merged 1 commit intoapache:masterfrom
szetszwo merged 1 commit intoapache:masterfrom
Conversation
adoroszlai
approved these changes
Dec 12, 2021
Contributor
adoroszlai
left a comment
There was a problem hiding this comment.
The dependency change looks good.
Note that ratis-hadoop has transitive dependency on log4j (via hadoop-common). I guess that's OK.
Should we also remove the log4j-related info below?
ratis/ratis-resource-bundle/src/main/resources/supplemental-models.xml
Lines 1155 to 1168 in a7555cf
Contributor
Author
Let's keep the license in supplemental-models.xml, which includes licenses for transitive dependencies. |
Contributor
Author
|
@adoroszlai , thanks a lot for reviewing this. |
symious
pushed a commit
to symious/ratis
that referenced
this pull request
Feb 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See https://issues.apache.org/jira/browse/RATIS-1467