RATIS-1470. Add peerId option to group list

[ferhui]

What changes were proposed in this pull request?

Add one new option peerId to shell command of group list

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/RATIS-1470

How was this patch tested?

Test by command line manually

[ferhui]

@maobaolong @szetszwo Can you please take a look? Thanks

[ferhui]

Here is the testing result.

bin/ratis sh group list -peers 'x01:9872,x02:9872,x03:9872' -peerId 'om1'
The peerId om1 (server x01:9872) is in 1 groups, and the groupIds is: [group-20E477FC5582]

[maobaolong]

@ferhui Thanks for this great contribution, this looks good overall,

Would you like to use org.apache.commons.cli.OptionGroup to simplify the exclusive logic between the SERVER_ADDRESS_OPTION_NAME and PEER_ID_OPTION_NAME options?

[ferhui]

@maobaolong Thanks for review! Updated

[maobaolong]

It LGTM, thanks @ferhui

[szetszwo]

@ferhui , thanks for working on this. Some minor comments inlined. Below is the suggested change.

  public int run(CommandLine cl) throws IOException {
    super.run(cl);
    final RaftPeerId peerId;
    final String address;
    if (cl.hasOption(PEER_ID_OPTION_NAME)) {
      peerId = RaftPeerId.getRaftPeerId(cl.getOptionValue(PEER_ID_OPTION_NAME));
      address = getRaftGroup().getPeer(peerId).getAddress();
    } else if (cl.hasOption(SERVER_ADDRESS_OPTION_NAME)) {
      address = cl.getOptionValue(SERVER_ADDRESS_OPTION_NAME);
      peerId = RaftUtils.getPeerId(parseInetSocketAddress(address));
    } else {
      throw new IllegalArgumentException(
          "Both " + PEER_ID_OPTION_NAME + " and " + SERVER_ADDRESS_OPTION_NAME + " options are missing.");
    }

    try(final RaftClient raftClient = RaftUtils.createClient(getRaftGroup())) {
      GroupListReply reply = raftClient.getGroupManagementApi(peerId).list();
      processReply(reply, () -> String.format("Failed to get group information of peerId %s (server %s)",
          peerId, address));
      printf(String.format("The peerId %s (server %s) is in %d groups, and the groupIds is: %s",
          peerId, address, reply.getGroupIds().size(), reply.getGroupIds()));
    }
    return 0;

  }

[szetszwo]

+1 the change looks good.

[ferhui]

@szetszwo @maobaolong Thanks for your review!