RATIS-1472. make use CachedThreadPool configurable.#566
Merged
szetszwo merged 4 commits intoapache:masterfrom Dec 18, 2021
Merged
RATIS-1472. make use CachedThreadPool configurable.#566szetszwo merged 4 commits intoapache:masterfrom
szetszwo merged 4 commits intoapache:masterfrom
Conversation
captainzmc
force-pushed
the
conf-thread
branch
from
e497bf4 to
1366d31
Compare
szetszwo
reviewed
Dec 16, 2021
Contributor
szetszwo
left a comment
szetszwo
left a comment
There was a problem hiding this comment.
@captainzmc , thanks for testing the performance. Two minor comments inlined.
| interface DataStream { | ||
| String PREFIX = RaftServerConfigKeys.PREFIX + ".data-stream"; | ||
|
|
||
| String USE_CACHED_THREAD_POOL_KEY = PREFIX + ".use.cached.thread.pool"; |
Contributor
There was a problem hiding this comment.
Let's change it to ".async.request.thread.pool.cached". Then, it is easy to see that this conf and ".async.request.thread.pool.size" are closely related.
| this.writeExecutor = ConcurrentUtils.newCachedThreadPool( | ||
| RaftServerConfigKeys.DataStream.asyncWriteThreadPoolSize(properties), | ||
| ConcurrentUtils.newThreadFactory(name + "-write-")); | ||
| this.useCachedThreadPool = RaftServerConfigKeys.DataStream.useCachedThreadPool(properties); |
Contributor
There was a problem hiding this comment.
Let's just make it a local variable.
szetszwo
reviewed
Dec 16, 2021
Comment on lines
+463
to
+468
| static boolean useCachedThreadPool(RaftProperties properties) { | ||
| return getBoolean(properties::getBoolean, ASYNC_REQUEST_THREAD_POOL_CACHED_KEY, | ||
| ASYNC_REQUEST_THREAD_POOL_CACHED_DEFAULT, getDefaultLog()); | ||
| } | ||
|
|
||
| static void setUseCachedThreadPool(RaftProperties properties, boolean useCached) { |
Contributor
There was a problem hiding this comment.
@captainzmc , thanks for the update. We also need to update the getter and setter method names. Otherwise, TestConfUtils will fail.
szetszwo
approved these changes
Dec 17, 2021
Contributor
szetszwo
left a comment
szetszwo
left a comment
There was a problem hiding this comment.
+1 the change looks good.
symious
pushed a commit
to symious/ratis
that referenced
this pull request
Feb 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
see: https://issues.apache.org/jira/browse/RATIS-1472