RATIS-1509. Remove GrpcOutputStream and the related conf GrpcConfigKeys.OutputStream.*#592
Conversation
adoroszlai
left a comment
adoroszlai
left a comment
There was a problem hiding this comment.
@szetszwo Instead of removing GrpcOutputStream right away, I think it would be nice to keep it (and its config) around as @Deprecated for at least one more release, referring users to RaftOutputStream. The test can be removed. What do you think?
|
@adoroszlai , GrpcOutputStream is not really a public API. It was known to be have bugs since the beginning as reported by RATIS-149. So, I think we should not keep it. Indeed, the conf was confusing. Someone has mistakenly using GrpcConfigKeys.OutputStream.RETRY_TIMES_KEY in arithmetic.cli.Server and filestoer.cli.Server. It has no effect at all. |
adoroszlai
left a comment
adoroszlai
left a comment
There was a problem hiding this comment.
was known to be have bugs since the beginning as reported by RATIS-149
I thought RATIS-149 was about the test.
OK, let's remove it. At least it should be mentioned in the release notes.
|
Sure. Let me update the title in order to mention the conf. |
szetszwo
changed the title
…ys.OutputStream.* (apache#592)
2 participants
See https://issues.apache.org/jira/browse/RATIS-1509