RATIS-1547. Make GrpcClientProtocolService and log to public#617
RATIS-1547. Make GrpcClientProtocolService and log to public#617captainzmc wants to merge 1 commit intoapache:masterfrom
Conversation
| public class GrpcClientProtocolService extends RaftClientProtocolServiceImplBase { | ||
| public static final Logger LOG = LoggerFactory.getLogger(GrpcClientProtocolService.class); |
There was a problem hiding this comment.
@captainzmc , sorry that GrpcClientProtocolService is not a public API. We should not change it for an Ozone unit test. We should fix the test instead.
| class GrpcClientProtocolService extends RaftClientProtocolServiceImplBase { | ||
| private static final Logger LOG = LoggerFactory.getLogger(GrpcClientProtocolService.class); | ||
| public class GrpcClientProtocolService extends RaftClientProtocolServiceImplBase { | ||
| public static final Logger LOG = LoggerFactory.getLogger(GrpcClientProtocolService.class); |
There was a problem hiding this comment.
I also encountered compile error while trying recent Ratis changes (RATIS-1515, etc.) with Ozone. But I think exposing LOG as public only for Ozone test is bad practice. We may be able to improve TestRatisPipelineLeader by using custom retry policy.
|
Thanks @szetszwo and @adoroszlai for the suggestion. Agree with you, let’s improve TestRatisPipelineLeader to avoid this error. |
|
@captainzmc , filed https://issues.apache.org/jira/browse/HDDS-6461 for updating Ratis snapshot version including fixing TestRatisPipelineLeader; see apache/ozone#3205 |
3 participants
What changes were proposed in this pull request?
see: https://issues.apache.org/jira/browse/RATIS-1547