RATIS-1570. Add getLeaderId method to DivisionInfo#640
Merged
szetszwo merged 4 commits intoapache:masterfrom May 9, 2022
Merged
RATIS-1570. Add getLeaderId method to DivisionInfo#640szetszwo merged 4 commits intoapache:masterfrom
szetszwo merged 4 commits intoapache:masterfrom
Conversation
Contributor
Author
|
@szetszwo PTAL |
szetszwo
requested changes
May 7, 2022
Contributor
szetszwo
left a comment
szetszwo
left a comment
There was a problem hiding this comment.
@OneSizeFitsQuorum , thanks for working on this! Please see the comments inlined.
ratis-server-api/src/main/java/org/apache/ratis/server/DivisionInfo.java
Outdated
Show resolved
Hide resolved
ratis-server/src/main/java/org/apache/ratis/server/impl/RaftServerImpl.java
Outdated
Show resolved
Hide resolved
OneSizeFitsQuorum
changed the title
OneSizeFitsQuorum
changed the title
szetszwo
reviewed
May 8, 2022
Contributor
szetszwo
left a comment
szetszwo
left a comment
There was a problem hiding this comment.
@OneSizeFitsQuorum , thanks for the update. Two minor comments inlined.
ratis-server-api/src/main/java/org/apache/ratis/server/DivisionInfo.java
Outdated
Show resolved
Hide resolved
ratis-server-api/src/main/java/org/apache/ratis/server/DivisionInfo.java
Outdated
Show resolved
Hide resolved
szetszwo
approved these changes
May 9, 2022
Contributor
szetszwo
left a comment
szetszwo
left a comment
There was a problem hiding this comment.
+1 the change looks good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see jira1570