Skip to content

RATIS-1615. Server should support listening on a specified network address#672

Merged
szetszwo merged 2 commits intoapache:masterfrom
lanicc:RATIS-1615
Jul 8, 2022
Merged

RATIS-1615. Server should support listening on a specified network address#672
szetszwo merged 2 commits intoapache:masterfrom
lanicc:RATIS-1615

Conversation

@lanicc
Copy link
Contributor

@lanicc lanicc commented Jul 7, 2022

What changes were proposed in this pull request?

Server should support listening on a specified network address

What is the link to the Apache JIRA

RATIS-1615

lanicc added 2 commits July 7, 2022 14:04
# Conflicts:
#	ratis-netty/src/main/java/org/apache/ratis/netty/server/NettyRpcService.java
@lanicc
Copy link
Contributor Author

lanicc commented Jul 7, 2022

Grpcservice also has this problem. Its constructor contains too many parameters so that I do not have a good idea to fix it.
Does anyone have a good idea

private GrpcService(RaftServer raftServer, Supplier<RaftPeerId> idSupplier,

  @SuppressWarnings("checkstyle:ParameterNumber") // private constructor
  private GrpcService(RaftServer raftServer, Supplier<RaftPeerId> idSupplier,
      int adminPort, GrpcTlsConfig adminTlsConfig,
      int clientPort, GrpcTlsConfig clientTlsConfig,
      int serverPort, GrpcTlsConfig serverTlsConfig,
      SizeInBytes grpcMessageSizeMax, SizeInBytes appenderBufferSize,
      SizeInBytes flowControlWindow,TimeDuration requestTimeoutDuration) {
   ...
  }

Copy link
Contributor

@szetszwo szetszwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 the change looks good.

@szetszwo szetszwo merged commit 54ae6e9 into apache:master Jul 8, 2022
symious pushed a commit to symious/ratis that referenced this pull request Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants