RATIS-1616. Include test source to check#674
Closed
xleoken wants to merge 1 commit intoapache:masterfrom
xleoken:build
Closed
RATIS-1616. Include test source to check#674xleoken wants to merge 1 commit intoapache:masterfrom xleoken:build
xleoken wants to merge 1 commit intoapache:masterfrom
xleoken:build
Conversation
szetszwo
reviewed
Jul 7, 2022
| <configuration> | ||
| <configLocation>dev-support/checkstyle.xml</configLocation> | ||
| <failOnViolation>false</failOnViolation> | ||
| <includeTestSourceDirectory>true</includeTestSourceDirectory> |
Contributor
There was a problem hiding this comment.
@leo65535 , thanks for working on this. Fixing the checkstyle warnings in test is good. However, let's don't run checkstyle for the tests. We should focus more on the main code instead of spending too much energy on the tests.
Member
Author
There was a problem hiding this comment.
Make sense. But it's better to keep the same rules for both source and test code. Developers will always meet the source code check style error, but test code is ok, this is not friendly for developers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Include test source to check.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/RATIS-1616
How was this patch tested?
(Please explain how this patch was tested. Ex: unit tests, manual tests)
(If this patch involves UI changes, please attach a screen-shot; otherwise, remove this)