RATIS-1618. Resolve the stream client concurrent reconnection problem#676
Merged
szetszwo merged 3 commits intoapache:masterfrom Jul 14, 2022
Merged
Conversation
Contributor
Author
|
What do you think of this change @szetszwo |
szetszwo
reviewed
Jul 8, 2022
Contributor
szetszwo
left a comment
szetszwo
left a comment
There was a problem hiding this comment.
@guohao-rosicky , the change looks good. Just two minor comments inlined.
Comment on lines
+229
to
+230
| } else { | ||
| workerGroup.shutdownGracefully(); |
Contributor
There was a problem hiding this comment.
The else is not needed since previous == null means already closed.
| if (channelFuture != null) { | ||
| Channel channel = channelFuture.syncUninterruptibly().channel(); | ||
| if (channel.isActive()) { | ||
| LOG.info("{} is already connect use exists channel {}", this, channel); |
Contributor
There was a problem hiding this comment.
Remove LOG.info since this is a client code.
Contributor
Author
|
Hi, @szetszwo. Thanks for review my PR. |
szetszwo
approved these changes
Jul 14, 2022
Contributor
szetszwo
left a comment
szetszwo
left a comment
There was a problem hiding this comment.
+1 the change looks good.
szetszwo
pushed a commit
that referenced
this pull request
Jul 14, 2022
symious
pushed a commit
to symious/ratis
that referenced
this pull request
Mar 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
When there is a network problem, reconnection is triggered.
If sending a lot of messages at the same time, multiple reconnections will be triggered.
In this case, we need to wait for the result of the first reconnection synchronously
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/RATIS-1618