RATIS-1624 Can't use set configuration to add a new Listener correctly#683
Merged
szetszwo merged 1 commit intoapache:masterfrom Jul 20, 2022
Merged
Conversation
codings-dan
reviewed
Jul 18, 2022
Contributor
codings-dan
left a comment
There was a problem hiding this comment.
@qian0817 Please take a look at the ci test error, https://github.com/apache/ratis/runs/7385492944?check_suite_focus=true#step:5:651
Contributor
Author
|
I tried to run |
szetszwo
approved these changes
Jul 20, 2022
Contributor
szetszwo
left a comment
There was a problem hiding this comment.
+1 the change looks good.
symious
pushed a commit
to symious/ratis
that referenced
this pull request
Mar 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
fix issue when set configuration to add a listener.
What is the link to the Apache JIRA
see https://issues.apache.org/jira/browse/RATIS-1624
How was this patch tested?