Skip to content

RATIS-1624 Can't use set configuration to add a new Listener correctly#683

Merged
szetszwo merged 1 commit intoapache:masterfrom
qian0817:fix-listener-set-configuration
Jul 20, 2022
Merged

RATIS-1624 Can't use set configuration to add a new Listener correctly#683
szetszwo merged 1 commit intoapache:masterfrom
qian0817:fix-listener-set-configuration

Conversation

@qian0817
Copy link
Copy Markdown
Contributor

What changes were proposed in this pull request?

fix issue when set configuration to add a listener.

What is the link to the Apache JIRA

see https://issues.apache.org/jira/browse/RATIS-1624

How was this patch tested?

Copy link
Copy Markdown
Contributor

@codings-dan codings-dan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@qian0817
Copy link
Copy Markdown
Contributor Author

I tried to run ./dev-support/checks/unit.sh -Pserver-tests on my machine but did not see the test fail. This should be a flaky test. @codings-dan

Copy link
Copy Markdown
Contributor

@szetszwo szetszwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 the change looks good.

@szetszwo szetszwo changed the title RATIS-1624: fix issue when set configuration to add a listener. RATIS-1624 Can't use set configuration to add a new Listener correctly Jul 20, 2022
@szetszwo szetszwo merged commit b8f050e into apache:master Jul 20, 2022
szetszwo pushed a commit that referenced this pull request Jul 21, 2022
symious pushed a commit to symious/ratis that referenced this pull request Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants