RATIS-1665. RaftLog avoid converting list#708
Merged
szetszwo merged 3 commits intoapache:masterfrom Aug 9, 2022
Merged
Conversation
JoeCqupt
force-pushed
the
avoid-converting-list
branch
from
669d24b to
884b55b
Compare
Contributor
Author
|
@szetszwo PTAL |
szetszwo
requested changes
Aug 8, 2022
ratis-server-api/src/main/java/org/apache/ratis/server/raftlog/RaftLogSequentialOps.java
Show resolved
Hide resolved
ratis-server/src/main/java/org/apache/ratis/server/impl/LeaderStateImpl.java
Outdated
Show resolved
Hide resolved
ratis-server/src/main/java/org/apache/ratis/server/impl/RaftServerImpl.java
Outdated
Show resolved
Hide resolved
szetszwo
approved these changes
Aug 9, 2022
Contributor
szetszwo
left a comment
szetszwo
left a comment
There was a problem hiding this comment.
+1 the change looks good.
codings-dan
pushed a commit
that referenced
this pull request
Aug 16, 2022
(cherry picked from commit 38a01cd)
symious
pushed a commit
to symious/ratis
that referenced
this pull request
Mar 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
https://github.com/apache/ratis/blob/master/ratis-server/src/main/java/org/apache/ratis/server/impl/RaftServerImpl.java#L1280
here a TODO comment, i do not know is it worth to implement it ?
i have finished it no matter how.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/RATIS-1665
How was this patch tested?
ci build