RATIS-1799. Make shell scripts in binary package executable#835
Merged
szetszwo merged 1 commit intoapache:masterfrom Mar 1, 2023
Merged
RATIS-1799. Make shell scripts in binary package executable#835szetszwo merged 1 commit intoapache:masterfrom
szetszwo merged 1 commit intoapache:masterfrom
Conversation
Member
Author
|
Cc @szetszwo @codings-dan PTAL. |
Member
Author
|
Hi @adoroszlai, I think it's nice to have this PR included in the next release (2.4.2 or 2.5.0). |
adoroszlai
approved these changes
Mar 1, 2023
Contributor
adoroszlai
left a comment
adoroszlai
left a comment
There was a problem hiding this comment.
Thanks @kaijchen for the patch, LGTM.
Before:
-rw-r--r-- root/root 2152 2020-01-22 16:10 apache-ratis-3.0.0-SNAPSHOT-bin/bin/ratis
-rw-r--r-- root/root 1150 2020-01-22 16:10 apache-ratis-3.0.0-SNAPSHOT-bin/examples/bin/client.sh
-rw-r--r-- root/root 1871 2020-01-22 16:10 apache-ratis-3.0.0-SNAPSHOT-bin/examples/bin/common.sh
-rw-r--r-- root/root 933 2020-01-22 16:10 apache-ratis-3.0.0-SNAPSHOT-bin/examples/bin/server.sh
-rw-r--r-- root/root 1610 2020-01-22 16:10 apache-ratis-3.0.0-SNAPSHOT-bin/examples/bin/start-all.sh
-rw-r--r-- root/root 922 2020-01-22 16:10 apache-ratis-3.0.0-SNAPSHOT-bin/examples/bin/stop-all.sh
-rw-r--r-- root/root 3626 2020-01-22 16:10 apache-ratis-3.0.0-SNAPSHOT-bin/libexec/ratis-shell-config.sh
After:
-rwxr-xr-x root/root 2152 2020-01-22 16:10 apache-ratis-3.0.0-SNAPSHOT-bin/bin/ratis
-rwxr-xr-x root/root 1150 2020-01-22 16:10 apache-ratis-3.0.0-SNAPSHOT-bin/examples/bin/client.sh
-rwxr-xr-x root/root 1871 2020-01-22 16:10 apache-ratis-3.0.0-SNAPSHOT-bin/examples/bin/common.sh
-rwxr-xr-x root/root 933 2020-01-22 16:10 apache-ratis-3.0.0-SNAPSHOT-bin/examples/bin/server.sh
-rwxr-xr-x root/root 1610 2020-01-22 16:10 apache-ratis-3.0.0-SNAPSHOT-bin/examples/bin/start-all.sh
-rwxr-xr-x root/root 922 2020-01-22 16:10 apache-ratis-3.0.0-SNAPSHOT-bin/examples/bin/stop-all.sh
-rwxr-xr-x root/root 3626 2020-01-22 16:10 apache-ratis-3.0.0-SNAPSHOT-bin/libexec/ratis-shell-config.sh
szetszwo
approved these changes
Mar 1, 2023
Contributor
szetszwo
left a comment
szetszwo
left a comment
There was a problem hiding this comment.
+1 the change looks good. Thanks for fixing this mysterious problem!
Contributor
|
@adoroszlai , thanks a lot for reviewing and testing this! |
szetszwo
pushed a commit
that referenced
this pull request
Mar 5, 2023
(cherry picked from commit 212690e)
kuszz
pushed a commit
to kuszz/ratis
that referenced
this pull request
Mar 7, 2023
symious
pushed a commit
to symious/ratis
that referenced
this pull request
Mar 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/RATIS-1799