Skip to content

RATIS-1802. GrpcServerProtocolService encounters IllegalStateException: call already closed. #839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SzyWilliam merged 1 commit into from
Mar 6, 2023
Merged

RATIS-1802. GrpcServerProtocolService encounters IllegalStateException: call already closed. #839

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion ratis-grpc/src/main/java/org/apache/ratis/grpc/server/GrpcServerProtocolService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,9 @@ StatusRuntimeException wrapException(Throwable e, REQUEST request) {

private void handleError(Throwable e, REQUEST request) {
GrpcUtil.warn(LOG, () -> getId() + ": Failed " + op + " request " + requestToString(request), e);
responseObserver.onError(wrapException(e, request));
if (isClosed.compareAndSet(false, true)) {
responseObserver.onError(wrapException(e, request));
}
}

private synchronized void handleReply(REPLY reply) {
Expand Down
2 changes: 1 addition & 1 deletion ratis-proto/src/main/proto/Grpc.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ service RaftServerProtocolService {
returns(stream ratis.common.InstallSnapshotReplyProto) {}

rpc readIndex(ratis.common.ReadIndexRequestProto)
returns(stream ratis.common.ReadIndexReplyProto) {}
returns(ratis.common.ReadIndexReplyProto) {}
}

service AdminProtocolService {
Expand Down