Skip to content

RATIS-1849. Remove unused getRaftClient#886

Merged
szetszwo merged 1 commit intoapache:masterfrom
tisonkun:remove-dead-code
Jun 15, 2023
Merged

RATIS-1849. Remove unused getRaftClient#886
szetszwo merged 1 commit intoapache:masterfrom
tisonkun:remove-dead-code

Conversation

@tisonkun
Copy link
Copy Markdown
Member

@tisonkun tisonkun commented Jun 14, 2023

What changes were proposed in this pull request?

This is a deconstructor to #308 that we no longer use getRaftClient

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/RATIS-1849

Please replace this section with the link to the Apache JIRA)

How was this patch tested?

Removed used code.

Signed-off-by: tison <wander4096@gmail.com>
@tisonkun tisonkun changed the title RATIS-XXX. Remove unused getRaftClient RATIS-1849. Remove unused getRaftClient Jun 15, 2023
@tisonkun
Copy link
Copy Markdown
Member Author

JIRA ticket filed. It seems CI failed unrelated.

cc @szetszwo @SzyWilliam

Copy link
Copy Markdown
Contributor

@szetszwo szetszwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 the change looks good. Thanks for the nice cleanup!

@szetszwo szetszwo merged commit 1b45527 into apache:master Jun 15, 2023
@tisonkun tisonkun deleted the remove-dead-code branch June 15, 2023 07:45
symious pushed a commit to symious/ratis that referenced this pull request Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants