Skip to content

RATIS-1879. Handle RaftLog corruption when unsafe flush is enabled.#911

Closed
szetszwo wants to merge 2 commits intoapache:masterfrom
szetszwo:RATIS-1879
Closed

RATIS-1879. Handle RaftLog corruption when unsafe flush is enabled.#911
szetszwo wants to merge 2 commits intoapache:masterfrom
szetszwo:RATIS-1879

Conversation

@szetszwo
Copy link
Copy Markdown
Contributor

@szetszwo szetszwo requested a review from SzyWilliam August 28, 2023 22:55
@SzyWilliam
Copy link
Copy Markdown
Member

Thanks @szetszwo very much for the patch! I'll use the patch to restart and see if we can fix it later on.

@szetszwo
Copy link
Copy Markdown
Contributor Author

szetszwo commented Sep 4, 2023

@SzyWilliam , as @OneSizeFitsQuorum mentioned in RATIS-1879. We already have WARN_AND_RETURN corruption policy. We does not seem to need this anymore.

@SzyWilliam
Copy link
Copy Markdown
Member

@szetszwo Thanks a lot! I was still worrying about this issue yesterday since it turned out that our user turned off the unsafeFlush and I made a mistake when firing a issue. The corruption problem may happen whether we enable unsafeFlush or not.
Now that I know CorruptionPolicy and it perfectly meet our needs.
Thanks @szetszwo @OneSizeFitsQuorum again!

@OneSizeFitsQuorum
Copy link
Copy Markdown
Contributor

@szetszwo it looks like you already addressed the issue reported by Ozone four years ago, which is really cool. Thank you for your thorough work!!!

@szetszwo
Copy link
Copy Markdown
Contributor Author

szetszwo commented Nov 5, 2023

Closing this since the problem is already fixed.

@szetszwo szetszwo closed this Nov 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants