RATIS-1888. Handle exception of readIndexAsync in gRPC readIndex impl#920
Merged
szetszwo merged 4 commits intoapache:masterfrom Sep 15, 2023
Merged
RATIS-1888. Handle exception of readIndexAsync in gRPC readIndex impl#920szetszwo merged 4 commits intoapache:masterfrom
szetszwo merged 4 commits intoapache:masterfrom
Conversation
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
Member
Author
|
Tests failed on:
Doesn't seem related. |
szetszwo
approved these changes
Sep 15, 2023
Contributor
szetszwo
left a comment
szetszwo
left a comment
There was a problem hiding this comment.
+1 the change looks good.
Contributor
Agree. Just have restarted the failed job. |
Member
|
@tisonkun Thanks a lot for the patch! It looks really concise. |
symious
pushed a commit
to symious/ratis
that referenced
this pull request
Mar 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
@szetszwo I noticed that we once made a
GrpcUtil.asyncCall(298c1a2) so I reuse the code with a few modification to adapt the readIndex type signature.I check all rpcs defined in Grpc.proto and the readIndex rpc is the only one remaining having this issue.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/RATIS-1888
How was this patch tested?
IMO, it's trivial and too detailed to test. But if we have some test infra I'm glad to work one.