RATIS-1886. AppendLog sleep fixed time cause significant drop in write throughput.#929
Merged
szetszwo merged 4 commits intoapache:masterfrom Oct 4, 2023
Merged
RATIS-1886. AppendLog sleep fixed time cause significant drop in write throughput.#929szetszwo merged 4 commits intoapache:masterfrom
szetszwo merged 4 commits intoapache:masterfrom
Conversation
Contributor
Author
|
Found an unrelated NPE in the previous build: https://github.com/apache/ratis/actions/runs/6345236213/job/17236854118?pr=929#step:5:988 Caused by: java.lang.NullPointerException: leaderState == null
at org.apache.ratis.server.impl.RoleInfo.shutdownLeaderState(RoleInfo.java:89)
at org.apache.ratis.server.impl.RaftServerImpl.changeToFollower(RaftServerImpl.java:584)
at org.apache.ratis.server.impl.RaftServerImpl.changeToFollowerAndPersistMetadata(RaftServerImpl.java:601)
at org.apache.ratis.server.impl.LeaderStateImpl.stepDown(LeaderStateImpl.java:676)
at org.apache.ratis.server.impl.LeaderStateImpl.checkLeadership(LeaderStateImpl.java:1080)
at org.apache.ratis.server.impl.LeaderStateImpl$EventProcessor.run(LeaderStateImpl.java:738)Will fix here since it is just a one line fix. |
SzyWilliam
approved these changes
Oct 3, 2023
Member
SzyWilliam
left a comment
SzyWilliam
left a comment
There was a problem hiding this comment.
+1 the changes look good to me. Thanks @szetszwo a lot for the fixing the throughput drop!
It seems that writes with small payloads (<10ms) are more sensitive to the AppendLog sleep time. With this patch and other recent improvements, I can't wait to see the throuput improvements in 3.0.0🥇
Contributor
Author
|
@SzyWilliam , Thanks a lot for reviewing this! Oops, I did not change the default to 1ms. Could you take a look again? |
Contributor
Author
|
@SzyWilliam , @codings-dan , thanks a lot for reviewing this! |
symious
pushed a commit
to symious/ratis
that referenced
this pull request
Mar 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See RATIS-1886