RATIS-872. Invalidate replied calls in retry cache.#942
RATIS-872. Invalidate replied calls in retry cache.#942SzyWilliam merged 1 commit intoapache:masterfrom
Conversation
|
The test failure is related: https://github.com/apache/ratis/actions/runs/6566630497/job/17837715966?pr=942#step:5:811 Since the calls are submitted asynchronously, we cannot assume the callIds are in order. Will remove the callId set from the server side and let the client send multiple replied callIds. |
There was a problem hiding this comment.
Thanks @szetszwo for the retry cache optimization! The change looks good to me.
Just a small question, since we do not carry repliedId for read-only requests in unorderedAsync, shall we also exclude them in orderedAsync?
This is a very good question! I handle blocking call and async calls separately. Actually, it is better to handle all the calls at the same time in RaftClientImpl, which will collect the replied call ids and use them to create requests. Let me update this after RATIS-1916. |
|
@SzyWilliam , moved all the replied callId handling to |
SzyWilliam
left a comment
There was a problem hiding this comment.
Sorry I missed out the update. +1 the change looks good. The code looks really neat!
|
@SzyWilliam , thanks a lot for reviewing and merging this! |
See RATIS-872.