Conversation
|
Why don't we put this in the rocketmq repo? It seems like a better option |
lizhanhui
reviewed
Oct 2, 2021
Member
Author
OK, we can consider move it to the main repo or add it as a git submodule. |
lizhanhui
reviewed
Oct 2, 2021
README.md
Outdated
|
|
||
| ## Reserved Fields | ||
|
|
||
| This API spec has reserved the numeric value of PB enum to 64 and the field numeric value of PB message to 64. These reserved values will be used by RocketMQ's official implementation. Beyond the reserved values are free to use by external organizations. No newline at end of file |
Contributor
There was a problem hiding this comment.
Messages and enumerations of the API spec reserve the first 64 fields for the evolution of RocketMQ exclusively. Vendor-specific extensions to the protocol are supposed to use fields beyond 64.
lizhanhui
reviewed
Oct 2, 2021
drpmma
reviewed
Oct 4, 2021
| reserved 2 to 64; | ||
| } | ||
|
|
||
| message EndTransactionRequest { |
Contributor
There was a problem hiding this comment.
It seems that tranStateTableOffset and commitLogOffset are not included in this protocol.
* Add transaction_state_table_offset and commit_log_offset in EndTransactionRequest and RecoverOrphanedTransactionRequest * Distinguish producer_group and consumer_group in NotifyClientTerminationRequest
This reverts commit 854b8f7.
Contributor
|
I'd merge this pull request and make it a base for further discussion and refinement. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have drafted the new rocketmq protocol and APIs, let's discuss it here or on the dev mailing list.