Skip to content

Conversation

@ifplusor
Copy link
Contributor

What is the purpose of the change

manage sync future and async future in single future table.

Brief changelog

merge m_futureTable and m_asyncFutureTable together.

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when a cross-module dependency exists.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@jonnxu
Copy link
Contributor

jonnxu commented Jun 13, 2019

LGTM

@jonnxu jonnxu added the enhancement New feature or request label Jul 8, 2019
@ifplusor ifplusor force-pushed the merge-future branch 2 times, most recently from c4124c7 to e1a727c Compare July 8, 2019 21:50
@jonnxu
Copy link
Contributor

jonnxu commented Jul 20, 2019

LGTM

@jonnxu jonnxu merged commit 6f3619c into apache:master Jul 21, 2019
@ifplusor ifplusor deleted the merge-future branch July 22, 2019 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants