Skip to content

Add license and notice binary to prepare release#176

Merged
jonnxu merged 1 commit intoapache:masterfrom
ShannonDing:licenses
Aug 16, 2019
Merged

Add license and notice binary to prepare release#176
jonnxu merged 1 commit intoapache:masterfrom
ShannonDing:licenses

Conversation

@ShannonDing
Copy link
Member

What is the purpose of the change

Add license for 3-rd party code

Brief changelog

add binary licenses.

Verifying this change

see in distribution directions

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when a cross-module dependency exists.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@ShannonDing ShannonDing added the enhancement New feature or request label Aug 16, 2019
@ShannonDing ShannonDing added this to the 1.2.3 milestone Aug 16, 2019
@jonnxu
Copy link
Contributor

jonnxu commented Aug 16, 2019

LGTM

@jonnxu jonnxu merged commit 1020914 into apache:master Aug 16, 2019
@ShannonDing ShannonDing deleted the licenses branch September 24, 2019 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants