Skip to content

Add rocketmq libpath to ldconf to support dlopen in CentOS#315

Merged
ShannonDing merged 1 commit into
apache:masterfrom
IterableTrucks:master
Jun 24, 2020
Merged

Add rocketmq libpath to ldconf to support dlopen in CentOS#315
ShannonDing merged 1 commit into
apache:masterfrom
IterableTrucks:master

Conversation

@IterableTrucks
Copy link
Copy Markdown
Contributor

@IterableTrucks IterableTrucks commented Jun 12, 2020

What is the purpose of the change

fix bug in rpm spec

Brief changelog

make librocketmq.so accessible to dlopen()

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when a cross-module dependency exists.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Merging #315 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #315   +/-   ##
=======================================
  Coverage   59.00%   59.00%           
=======================================
  Files         205      205           
  Lines       12987    12987           
=======================================
  Hits         7663     7663           
  Misses       5324     5324           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b884f17...0cce938. Read the comment docs.

@ShannonDing ShannonDing added the enhancement New feature or request label Jun 15, 2020
@ShannonDing ShannonDing changed the title fix rpm spec Add rocketmq libpath to ldconf to support dlopen in CentOS Jun 15, 2020
@ShannonDing ShannonDing merged commit 999755b into apache:master Jun 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants