Skip to content

[ISSUE #35]C-API unable to get the right message properties，such as getKeys ,getTags #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ShannonDing merged 2 commits into from
Dec 25, 2018
Merged

[ISSUE #35]C-API unable to get the right message properties，such as getKeys ,getTags #36

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e8796e6
fix bug: get Message info fail ,including getTags、getKeys、getTopic、ge…
wlliqipeng Dec 20, 2018
5ce84d2
Fix a temporary pointer bug from getProperty
wlliqipeng Dec 25, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions include/MQMessage.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,17 +40,17 @@ class ROCKETMQCLIENT_API MQMessage {
MQMessage(const MQMessage& other);
MQMessage& operator=(const MQMessage& other);

void setProperty(const std::string& name, const std::string& value);
std::string getProperty(const std::string& name) const;
void setProperty(const std::string& name, const std::string& value) ;
const std::string & getProperty(const std::string& name) const;

std::string getTopic() const;
const std::string &getTopic() const;
void setTopic(const std::string& topic);
void setTopic(const char* body, int len);

std::string getTags() const;
const std::string &getTags() const;
void setTags(const std::string& tags);

std::string getKeys() const;
const std::string &getKeys() const;
void setKeys(const std::string& keys);
void setKeys(const std::vector<std::string>& keys);

Expand All @@ -63,7 +63,7 @@ class ROCKETMQCLIENT_API MQMessage {
int getFlag() const;
void setFlag(int flag);

std::string getBody() const;
const std::string &getBody() const;
void setBody(const char* body, int len);
void setBody(const std::string& body);

Expand Down
17 changes: 10 additions & 7 deletions src/message/MQMessage.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,13 +93,16 @@ void MQMessage::setProperty(const string& name, const string& value) {
m_properties[name] = value;
}

string MQMessage::getProperty(const string& name) const {
const string & MQMessage::getProperty(const string& name) const {
map<string, string>::const_iterator it = m_properties.find(name);

return (it == m_properties.end()) ? "" : (*it).second;
if(it == m_properties.end()){
return "";
}else{
return it->second;
}
}

string MQMessage::getTopic() const { return m_topic; }
const string& MQMessage::getTopic() const { return m_topic; }

void MQMessage::setTopic(const string& topic) { m_topic = topic; }

Expand All @@ -108,13 +111,13 @@ void MQMessage::setTopic(const char* body, int len) {
m_topic.append(body, len);
}

string MQMessage::getTags() const { return getProperty(PROPERTY_TAGS); }
const string& MQMessage::getTags() const { return getProperty(PROPERTY_TAGS); }

void MQMessage::setTags(const string& tags) {
setProperty(PROPERTY_TAGS, tags);
}

string MQMessage::getKeys() const { return getProperty(PROPERTY_KEYS); }
const string& MQMessage::getKeys() const { return getProperty(PROPERTY_KEYS); }

void MQMessage::setKeys(const string& keys) {
setProperty(PROPERTY_KEYS, keys);
Expand Down Expand Up @@ -174,7 +177,7 @@ int MQMessage::getFlag() const { return m_flag; }

void MQMessage::setFlag(int flag) { m_flag = flag; }

string MQMessage::getBody() const { return m_body; }
const string& MQMessage::getBody() const { return m_body; }

void MQMessage::setBody(const char* body, int len) {
m_body.clear();
Expand Down