[Issue#94] Support send batch message to broker by jonnxu · Pull Request #95 · apache/rocketmq-client-cpp

jonnxu · 2019-02-09T16:26:31Z

What is the purpose of the change

#94 Support send batch message to broker

Brief changelog

Add two new APIs:
SendResult send(std::vector& msgs);
SendResult send(std::vector& msgs, const MQMessageQueue& mq);

Verifying this change

Producer send one batch message:

./bin/BatchProducer -t batch -m 1 -c test2222 -T 1 -n 127.0.0.1:9876 -g g1 nameserver: 101.132.96.164:9876
topic: batch
groupname: g1
produce content: test2222msgbody for test
msg count: 1
thread count: 1
tps_thread_ is null
send RT more than: 2807 ms with msgid:
per msg time: 2807ms
========================finished==============================

consumer receive three message:

./bin/PushConsumer -t batch -n 127.0.0.1:9876 -g g0 -m 10000 -T 1
nameserver: 127.0.0.1:9876
topic: batch
groupname: g0
produce content: msgbody for test
msg count: 10000
thread count: 1
tps_thread_ is null
msg: MessageExt [queueId=0, storeSize=196, queueOffset=48, sysFlag=0, bornTimestamp=1549729233501, bornHost=127.0.0.1, storeTimestamp=1549729234903, storeHost=127.0.0.1, msgId=730010AC000083060000E06492330100, commitLogOffset=365601006, bodyCRC=1949078420, reconsumeTimes=0, preparedTransactionOffset=0, Message [topic=batch, flag=0, tag=]]
body: test2222msgbody for test
TAGS : *
UNIQ_KEY : 730010AC000083060000E06492330100
WAIT : true
property1 : value1
msg: MessageExt [queueId=0, storeSize=213, queueOffset=49, sysFlag=0, bornTimestamp=1549729233501, bornHost=127.0.0.1, storeTimestamp=1549729234903, storeHost=127.0.0.1, msgId=730010AC000083060000E06492330200, commitLogOffset=365601202, bodyCRC=1949078420, reconsumeTimes=0, preparedTransactionOffset=0, Message [topic=batch, flag=0, tag=]]
body: test2222msgbody for test
TAGS : *
UNIQ_KEY : 730010AC000083060000E06492330200
WAIT : true
property1 : value1
property2 : value2
msg: MessageExt [queueId=0, storeSize=230, queueOffset=50, sysFlag=0, bornTimestamp=1549729233501, bornHost=127.0.0.1, storeTimestamp=1549729234903, storeHost=127.0.0.1, msgId=730010AC000083060000E06492330300, commitLogOffset=365601415, bodyCRC=1949078420, reconsumeTimes=0, preparedTransactionOffset=0, Message [topic=batch, flag=0, tag=*]]
body: test2222msgbody for test
TAGS : *
UNIQ_KEY : 730010AC000083060000E06492330300
WAIT : true
property1 : value1
property2 : value2
property3 : value3

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when a cross-module dependency exists.
If this contribution is large, please file an Apache Individual Contributor License Agreement.

jovany-wang

Left some minor comments.
I'll take a look at this PR again in this weekend.

Another suggestion, could we use the OO in this example? So that we shouldn't define some global variable like g_mutex, etc. How do you think of this?

jovany-wang · 2019-02-15T10:03:53Z

example/BatchProducer.cpp

+* See the License for the specific language governing permissions and
+* limitations under the License.
+*/
+#include <stdio.h>


A new line after copyright?

jovany-wang · 2019-02-15T10:04:34Z

example/BatchProducer.cpp

+#include <mutex>
+#include <thread>
+#include <vector>
+#include "common.h"


A new line before line28?

i don't think need a new line between header files

jovany-wang · 2019-02-15T10:05:16Z

example/BatchProducer.cpp

+#include "common.h"
+
+using namespace rocketmq;
+using namespace std;


better to remove this using namespace std; statement.

it doesn't matter for cpp file

jovany-wang · 2019-02-15T10:06:04Z

example/BatchProducer.cpp

+
+using namespace rocketmq;
+using namespace std;
+boost::atomic<bool> g_quit;


Let's use std::atomic instead of boost::atomic.

Or do you have any other consideration?

copy from another sample

jovany-wang · 2019-02-15T10:10:48Z

example/BatchProducer.cpp

+        msgs.push_back(msg2);
+        msgs.push_back(msg3);
+        try {
+            auto start = std::chrono::system_clock::now();


Suggested change

auto start = std::chrono::system_clock::now();

auto start = UtilAll::currentTimeMillis();

jovany-wang · 2019-02-15T10:11:05Z

example/BatchProducer.cpp

+            auto duration =
+                    std::chrono::duration_cast<std::chrono::milliseconds>(end - start);
+            if (duration.count() >= 500) {
+                std::cout << "send RT more than: " << duration.count()


use log instead of std::cout

i suggest use std::cout or printf for samples because it can see the output in screen at once

jovany-wang · 2019-02-15T10:11:26Z

include/BatchMessage.h

+        static std::string encode(MQMessage &message);
+    };
+}
+#endif


a new line at the end of this line.

messense · 2019-03-14T06:22:55Z

Any plan on adding send batch message APIs to C APIs?

Support send batch message

jonnxu added 2 commits February 9, 2019 23:50

Support send batch message

55c376d

Process the exception branch for BatchProducer

a67d724

ShannonDing added this to the 1.2.2 milestone Feb 12, 2019

jovany-wang suggested changes Feb 15, 2019

View reviewed changes

jonnxu added 3 commits February 23, 2019 20:19

Merge branch 'master' into master

0ec503d

remove the tab key

1f3621e

Merge branch 'master' into master

e67c0a0

ShannonDing merged commit dcba721 into apache:master Mar 14, 2019

ShannonDing added the enhancement New feature or request label Mar 14, 2019

ifplusor pushed a commit to ifplusor/rocketmq-client-cpp that referenced this pull request Mar 15, 2019

[Issue#94] Support send batch message to broker (apache#95)

5d8abf9

Support send batch message

ifplusor pushed a commit to ifplusor/rocketmq-client-cpp that referenced this pull request Mar 15, 2019

[Issue#94] Support send batch message to broker (apache#95)

e4854a7

Support send batch message

	auto start = std::chrono::system_clock::now();
	auto start = UtilAll::currentTimeMillis();

Conversation

jonnxu commented Feb 9, 2019

What is the purpose of the change

Brief changelog

Verifying this change

Uh oh!

jovany-wang left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

messense commented Mar 14, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

jovany-wang left a comment •

edited

Loading