Skip to content

Open Api tp set consume message max size#205

Closed
ShannonDing wants to merge 3 commits intoapache:nativefrom
ShannonDing:ConsumerMaxSize
Closed

Open Api tp set consume message max size#205
ShannonDing wants to merge 3 commits intoapache:nativefrom
ShannonDing:ConsumerMaxSize

Conversation

@ShannonDing
Copy link
Member

What is the purpose of the change

Allow user to set the max size of consume message

Brief changelog

add api

Verifying this change

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when a cross-module dependency exists.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@ShannonDing ShannonDing added the enhancement New feature or request label Sep 13, 2019
@ShannonDing ShannonDing added this to the Native-2.0.0-alpha3 milestone Sep 13, 2019
@codecov-io
Copy link

Codecov Report

Merging #205 into native will decrease coverage by 0.4%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           native     #205      +/-   ##
==========================================
- Coverage   26.52%   26.12%   -0.41%     
==========================================
  Files          46       46              
  Lines        4674     4677       +3     
==========================================
- Hits         1240     1222      -18     
- Misses       3262     3282      +20     
- Partials      172      173       +1
Impacted Files Coverage Δ
consumer/option.go 28.57% <0%> (-1.62%) ⬇️
consumer/statistics.go 61.73% <0%> (-7.83%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8d5e46...4870e14. Read the comment docs.

@ShannonDing ShannonDing added the duplicate This issue or pull request already exists label Sep 15, 2019
@ShannonDing
Copy link
Member Author

duplicate to #206

@ShannonDing ShannonDing deleted the ConsumerMaxSize branch October 14, 2019 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

duplicate This issue or pull request already exists enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants