Skip to content

[ISSUE #338] fix(route): update route #339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
wenfengwang merged 1 commit into from
Dec 24, 2019
Merged

[ISSUE #338] fix(route): update route #339

wenfengwang merged 1 commit into from
Dec 24, 2019

Conversation

@xujianhai666
Copy link
Member

@xujianhai666 xujianhai666 commented Dec 23, 2019

  • fix producer publish update logic
  • fix consumer subcription update logic

Closes #338

@xujianhai666
fix(route): update route
1750b8b 
- fix producer publish update logic
- fix consumer subcription update logic

Closes apache#338
@codecov-io
Copy link

codecov-io commented Dec 23, 2019

Codecov Report

Merging #339 into native will increase coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           native     #339      +/-   ##
==========================================
+ Coverage   26.28%   26.29%   +<.01%     
==========================================
  Files          47       47              
  Lines        5536     5534       -2     
==========================================
  Hits         1455     1455              
+ Misses       3890     3888       -2     
  Partials      191      191
Impacted Files Coverage Δ
internal/namesrv.go 66% <ø> (ø) ⬆️
internal/mock_namesrv.go 0% <0%> (ø) ⬆️
internal/route.go 9.31% <0%> (ø) ⬆️
internal/mock_client.go 0% <0%> (ø) ⬆️
internal/client.go 0.24% <0%> (ø) ⬆️
producer/producer.go 29.68% <0%> (-0.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df01296...1750b8b. Read the comment docs.

@wenfengwang wenfengwang changed the title fix(route): update route [ISSUE #338] fix(route): update route Dec 24, 2019
@wenfengwang wenfengwang self-requested a review December 24, 2019 02:33
@wenfengwang wenfengwang added this to the 2.0.0-RC1 milestone Dec 24, 2019
wenfengwang
wenfengwang approved these changes Dec 24, 2019
View reviewed changes
Copy link
Member

@wenfengwang wenfengwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ShannonDing ShannonDing added the bug Something isn't working label Dec 24, 2019
@wenfengwang wenfengwang merged commit be743f7 into apache:native Dec 24, 2019
@wenfengwang wenfengwang mentioned this pull request Dec 24, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wenfengwang wenfengwang wenfengwang approved these changes

@ShannonDing ShannonDing ShannonDing approved these changes

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

2.0.0-RC1

Development

Successfully merging this pull request may close these issues.

4 participants

@xujianhai666 @codecov-io @wenfengwang @ShannonDing