Skip to content

Conversation

@francisoliverlee
Copy link
Member

@francisoliverlee francisoliverlee commented Aug 12, 2021

What is the purpose of the change

#711

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when a cross-module dependency exists.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@francisoliverlee francisoliverlee linked an issue Aug 12, 2021 that may be closed by this pull request
@maixiaohai
Copy link
Contributor

@francisoliverlee This pr has been merged. #712

@maixiaohai maixiaohai added the duplicate This issue or pull request already exists label Aug 25, 2021
Copy link
Member

@ShannonDing ShannonDing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it will be closed later.

@wenfengwang wenfengwang closed this Sep 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

duplicate This issue or pull request already exists

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[bug] The Unsubscribe() interface influence retrytopic

4 participants