Skip to content

Conversation

@aaron-ai
Copy link
Member

Fixes #156

@aaron-ai
Copy link
Member Author

@xdkxlk PTAL

@codecov-commenter
Copy link

Codecov Report

Merging #157 (75eac59) into master (7e6dc0b) will increase coverage by 0.21%.
The diff coverage is 60.00%.

@@             Coverage Diff              @@
##             master     #157      +/-   ##
============================================
+ Coverage     30.63%   30.84%   +0.21%     
- Complexity      550      552       +2     
============================================
  Files           189      189              
  Lines          8612     8624      +12     
  Branches        283      284       +1     
============================================
+ Hits           2638     2660      +22     
+ Misses         5835     5822      -13     
- Partials        139      142       +3     
Flag Coverage Δ
java 52.34% <60.00%> (+0.41%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...pache/rocketmq/client/java/impl/ClientManager.java 100.00% <ø> (ø)
...mq/client/java/impl/consumer/ProcessQueueImpl.java 60.59% <33.33%> (-0.42%) ⬇️
...apache/rocketmq/client/java/rpc/RpcClientImpl.java 85.50% <66.66%> (-4.82%) ⬇️
...e/rocketmq/client/java/impl/ClientManagerImpl.java 82.35% <100.00%> (ø)
...cketmq/client/java/impl/consumer/ConsumerImpl.java 74.59% <100.00%> (-0.21%) ⬇️
...g/apache/rocketmq/client/java/impl/ClientImpl.java 38.46% <0.00%> (+5.53%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@aaron-ai aaron-ai added type/bug Something isn't working Java labels Aug 18, 2022
@xdkxlk
Copy link

xdkxlk commented Aug 18, 2022

LGTM

@aaron-ai aaron-ai merged commit 7eeb300 into apache:master Aug 18, 2022
@aaron-ai aaron-ai changed the title Bugfix: blocking message receiveing may exhausts all async worker threads Bugfix: blocking message receiving may exhaust all async worker threads Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Java type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The blocking call in RpcClientImpl#receiveMessage may exhaust all async worker threads.

3 participants