Skip to content

Conversation

@ShadowySpirits
Copy link
Member

Brief changelog for rust client:

  1. Support changing invisible duration RPC
  2. Suppress the warning about no settings telemetry command handler

Signed-off-by: SSpirits <admin@lv5.moe>
@codecov-commenter
Copy link

codecov-commenter commented Oct 15, 2023

Codecov Report

Merging #623 (7bdd864) into master (1c43ebe) will decrease coverage by 0.02%.
Report is 12 commits behind head on master.
The diff coverage is 49.05%.

@@             Coverage Diff              @@
##             master     #623      +/-   ##
============================================
- Coverage     46.29%   46.28%   -0.02%     
  Complexity      650      650              
============================================
  Files           207      207              
  Lines         11990    12092     +102     
  Branches       3405     3507     +102     
============================================
+ Hits           5551     5597      +46     
- Misses         6195     6249      +54     
- Partials        244      246       +2     
Flag Coverage Δ
rust 79.51% <49.05%> (-1.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
rust/src/model/common.rs 98.59% <ø> (ø)
rust/src/model/message.rs 95.90% <100.00%> (ø)
rust/src/util.rs 100.00% <100.00%> (ø)
rust/src/model/transaction.rs 82.29% <0.00%> (ø)
rust/src/simple_consumer.rs 78.80% <0.00%> (-5.50%) ⬇️
rust/src/session.rs 46.33% <0.00%> (-1.82%) ⬇️
rust/src/client.rs 79.27% <69.56%> (-1.26%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

ack_result.unwrap_err()
);
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about controlling this through a feature, instead of commenting

@lizhanhui
Copy link
Contributor

And there are a few clippy warnings to fix

Signed-off-by: SSpirits <admin@lv5.moe>
Signed-off-by: SSpirits <admin@lv5.moe>
Signed-off-by: SSpirits <admin@lv5.moe>
@lizhanhui lizhanhui merged commit 9fec02b into apache:master Oct 16, 2023
@ShadowySpirits ShadowySpirits deleted the rust_change_invisible_duration branch October 16, 2023 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants