Skip to content

Conversation

@ityestop
Copy link
Contributor

What is the purpose of the change

XXXXX

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@odbozhou odbozhou changed the title [ISSUE #424] 调整WorkerSourceTask的Topic的获取顺序 [ISSUE #424] Adjust the order in which WorkerSourceTask topics are acquired Feb 17, 2023
@odbozhou odbozhou merged commit d52a79d into apache:master Feb 17, 2023
@sunxiaojian
Copy link
Contributor

sunxiaojian commented Feb 17, 2023

顺序修改后会造成所有的 ,使用动态的topic功能不能使用

如: 通过transform分流后的功能,debezium插件中动态topic 功能

odbozhou added a commit to odbozhou/rocketmq-connect that referenced this pull request Feb 22, 2023
sunxiaojian pushed a commit that referenced this pull request Feb 22, 2023
sunxiaojian pushed a commit to sunxiaojian/rocketmq-connect that referenced this pull request Feb 24, 2023
…are acquired (apache#426)

Co-authored-by: cchu <cchu@gaojihealth.com>
sunxiaojian pushed a commit to sunxiaojian/rocketmq-connect that referenced this pull request Feb 24, 2023
sunxiaojian pushed a commit to sunxiaojian/rocketmq-connect that referenced this pull request Feb 24, 2023
…are acquired (apache#426)

Co-authored-by: cchu <cchu@gaojihealth.com>
sunxiaojian pushed a commit to sunxiaojian/rocketmq-connect that referenced this pull request Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants