[ISSUE #399] Use AbstractFileStore.class for resource loading#400
Open
flying-musk wants to merge 1 commit intoapache:masterfrom
Open
[ISSUE #399] Use AbstractFileStore.class for resource loading#400flying-musk wants to merge 1 commit intoapache:masterfrom
flying-musk wants to merge 1 commit intoapache:masterfrom
Conversation
Author
|
Gentle follow-up in case this slipped through. This is a small, behavior-preserving cleanup that makes the resource lookup context explicit in I also verified the project still builds and the test suite passes locally:
Happy to revise if needed. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
This PR makes resource loading in
AbstractFileStoreuse an explicit class reference instead ofgetClass().The current code uses:
getClass().getResourceAsStream("/" + fileName)Since
AbstractFileStoreis designed to be extended, this makes the lookup depend on the runtime subclass, which can introduce inheritance-related ambiguity and make the behavior less explicit for future maintenance.Using
AbstractFileStore.class.getResourceAsStream(...)makes the resource lookup context explicit and stable.Brief changelog
getClass().getResourceAsStream("/" + fileName)withAbstractFileStore.class.getResourceAsStream("/" + fileName)inAbstractFileStoreVerifying this change
mvn test