[ISSUE #135]Support Broker clusters in Conntroller mode#136
Merged
caigy merged 2 commits intoapache:masterfrom Nov 3, 2022
Merged
[ISSUE #135]Support Broker clusters in Conntroller mode#136caigy merged 2 commits intoapache:masterfrom
caigy merged 2 commits intoapache:masterfrom
Conversation
gobbq
reviewed
Nov 2, 2022
| NameServers string `json:"nameServers,omitempty"` | ||
| // ClusterMode defines the way to be a broker cluster, valid values can be one of the following: | ||
| // STATIC(default), CONTROLLER, CONTAINER | ||
| ClusterMode string `json:"clusterMode,omitempty"` |
There was a problem hiding this comment.
What does it mean when the value of this variable is CONTAINER?
Contributor
Author
There was a problem hiding this comment.
This value is for Broker Container mode: https://github.com/apache/rocketmq/blob/develop/docs/cn/BrokerContainer.md
There was a problem hiding this comment.
This value is for
Broker Containermode: https://github.com/apache/rocketmq/blob/develop/docs/cn/BrokerContainer.md
If this function is not implemented in version 0.4.0, we'd better deal with the boundaries well
gobbq
approved these changes
Nov 3, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
fix #135
Brief changelog
Add CRD and controller logic for DLedger Controller, which enables auto-switching broker clusters.
Verifying this change
Please go through this checklist to help us incorporate your contribution quickly and easily.
Notice:
It would be helpful if you could finish the following checklist (the last one is not necessary) before request the community to review your PR.[ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.make docker-buildto build docker image for operator, try your changes from Pod inside your Kubernetes cluster, not just locally. Also provide screenshots to show that the RocketMQ cluster is healthy after the changes.make manifeststo make sure the CRD files are updated.