Add Contribute Guide Document(cn) to new official website#151
Merged
RongtongJin merged 3 commits intoapache:new-official-websitefrom Jul 9, 2022
Merged
Add Contribute Guide Document(cn) to new official website#151RongtongJin merged 3 commits intoapache:new-official-websitefrom
RongtongJin merged 3 commits intoapache:new-official-websitefrom
Conversation
…29how-to-contribute.md" modified: "docs/08-\350\264\241\347\214\256\346\214\207\345\215\227/30code-guidelines.md" modified: "docs/08-\350\264\241\347\214\256\346\214\207\345\215\227/31pull-request.md" modified: "docs/08-\350\264\241\347\214\256\346\214\207\345\215\227/32release-manual.md" new file: docs/picture/30code-guidelines/1_codestyle.png new file: docs/picture/30code-guidelines/2_ApacheV2.png new file: docs/picture/30code-guidelines/3_ApacheCopyRight.png new file: docs/picture/30code-guidelines/4_FileHeader.png new file: docs/picture/31pull-request/1_Github.png new file: docs/picture/31pull-request/2_compare.png new file: docs/picture/31pull-request/3_Write.png
tsunghanjacktsai
suggested changes
Jul 7, 2022
Contributor
tsunghanjacktsai
left a comment
tsunghanjacktsai
left a comment
There was a problem hiding this comment.
Hi @liyijuan ,
Thx for your contribution. It seems more formal and professional since your last PR. Only some subtle errors that I pointed out in the review. Hope you could help us correct it. Well done 👍
docs/08-贡献指南/29how-to-contribute.md
Outdated
Contributor
There was a problem hiding this comment.
user mailing lists -> user mailing list
stackoverflow rocketmq -> Stack Overflow #rocketmq
Contributor
Author
There was a problem hiding this comment.
Thx, it seems more better
docs/08-贡献指南/29how-to-contribute.md
Outdated
Contributor
There was a problem hiding this comment.
user mailing lists -> User mailing list
docs/08-贡献指南/29how-to-contribute.md
Outdated
Contributor
There was a problem hiding this comment.
development mailing list -> Development mailing list
docs/08-贡献指南/29how-to-contribute.md
Outdated
Contributor
There was a problem hiding this comment.
Github issue -> GitHub Issue
docs/08-贡献指南/31pull-request.md
Outdated
docs/08-贡献指南/31pull-request.md
Outdated
docs/08-贡献指南/31pull-request.md
Outdated
docs/08-贡献指南/31pull-request.md
Outdated
docs/08-贡献指南/31pull-request.md
Outdated
…29how-to-contribute.md" modified: "docs/08-\350\264\241\347\214\256\346\214\207\345\215\227/30code-guidelines.md" modified: "docs/08-\350\264\241\347\214\256\346\214\207\345\215\227/31pull-request.md" modified: "docs/08-\350\264\241\347\214\256\346\214\207\345\215\227/32release-manual.md"
RongtongJin
approved these changes
Jul 9, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please do not create a Pull Request without creating an issue first.
What is the purpose of the change
translate en document into cn
Brief changelog
Verifying this change
Images can be displayed normally
Follow this checklist to help us incorporate your contribution quickly and easily:
[ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyleto make sure basic checks pass. Runmvn clean install -DskipITsto make sure unit-test pass. Runmvn clean test-compile failsafe:integration-testto make sure integration-test pass.