Skip to content

Conversation

@zplovekq
Copy link

for windows,there is some different for the source code and binary release.

Please do not create a Pull Request without creating an issue first.

What is the purpose of the change

XXXXX

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

for windows,there is some different for the source code and binary release.
Copy link
Contributor

@tsunghanjacktsai tsunghanjacktsai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @zplovekq ,

Many thanks for your contribution. As you could see, we've got many problems within our current documentation. Thus, we're now building a brand new version within the new-official-website branch (https://github.com/apache/rocketmq-site/tree/new-official-website/docs). Would you mind helping us improve the documentation there instead of this old one?

@zplovekq
Copy link
Author

Hi @zplovekq ,

Many thanks for your contribution. As you could see, we've got many problems within our current documentation. Thus, we're now building a brand new version within the new-official-website branch (https://github.com/apache/rocketmq-site/tree/new-official-website/docs). Would you mind helping us improve the documentation there instead of this old one?

Thanks for your recognizaion!
I will pr soon~

@zplovekq zplovekq closed this Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants