You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'd like to bring attention to a small bugfix PR that's ready for review but appears to be waiting on a committer to trigger CI (I understand this is standard for first-time contributors):
Summary: DefaultLitePullConsumerImpl.taskTable is mutated by three methods (updatePullTask, updateAssignPullTask, removePullTask) via a non-atomic check-then-act sequence (containsKey then put in startPullTask), with no synchronization.
The fix wraps the three mutating methods in synchronized (this.taskTable), mirroring the locking pattern already used by the sibling AssignedMessageQueue class. Included a test (DefaultLitePullConsumerImplTaskTableRaceTest) that reproduces the race pre-fix and passes post-fix.
Automated review has already gone over the change. Would appreciate it if a committer could take a look and kick off CI when convenient — happy to address any feedback.
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Hi all,
I'd like to bring attention to a small bugfix PR that's ready for review but appears to be waiting on a committer to trigger CI (I understand this is standard for first-time contributors):
PR: #10631
Issue: #10630
Summary: DefaultLitePullConsumerImpl.taskTable is mutated by three methods (updatePullTask, updateAssignPullTask, removePullTask) via a non-atomic check-then-act sequence (containsKey then put in startPullTask), with no synchronization.
The fix wraps the three mutating methods in synchronized (this.taskTable), mirroring the locking pattern already used by the sibling AssignedMessageQueue class. Included a test (DefaultLitePullConsumerImplTaskTableRaceTest) that reproduces the race pre-fix and passes post-fix.
Automated review has already gone over the change. Would appreciate it if a committer could take a look and kick off CI when convenient — happy to address any feedback.
Regards,
Somak
All reactions