[Bug] JRaftController handle broker heartbeat request mechanism not work

[chenxu80]

Before Creating the Bug Report

• I found a bug, not just asking a question, which should be created in GitHub Discussions.

• I have searched the GitHub Issues and GitHub Discussions of this repository and believe that this is not a duplicate.

• I have confirmed that this bug belongs to the current repository, not other repositories of RocketMQ.

Runtime platform environment

ubuntu 24.04

RocketMQ version

rocketmq-all-5.5.0

JDK Version

Oracle JRE 8u251

Describe the Bug

RaftBrokerHeartBeatManager.scanNotActiveBroker() uses firstReceivedHeartbeatTime with a reversed time check, so after the initial wait window passes, it keeps skipping the scan forever instead of starting it. As a result, inactive broker detection and the follow-up re-election flow may never run.

Steps to Reproduce

• make a broker into error status like OOM but broker connection remains alive
• JraftController will not find that this broker node is out of service

What Did You Expect to See?

JRaftController can remove this broker node from alive set

What Did You See Instead?

JRaftController did nothing

Additional Context

No response

[oss-sentinel-ai]

Issue Evaluation

Category: type/bug | Status: Not a Bug

Thank you for the detailed report. After verifying the source code, the logic appears to be correct.

Analysis: The condition at RaftBrokerHeartBeatManager.java:191-195:

if (this.firstReceivedHeartbeatTime == -1 ||
    this.firstReceivedHeartbeatTime + jRaftScanWaitTimeoutMs > System.currentTimeMillis()) {
    return; // skip
}

• When now - firstReceivedHeartbeatTime < waitTimeout → condition is true → return (skip scanning, within grace window)
• When now - firstReceivedHeartbeatTime >= waitTimeout → condition is false → method proceeds to evict inactive brokers

This is a startup grace window (default 1000ms) to avoid premature eviction after controller cluster restart. After the window elapses, scanning and eviction work correctly.

Reference: Unit test testScanNotActiveBrokerSuccess in RaftBrokerHeartBeatManagerTest exercises the post-window path and confirms eviction works as designed.

---

Automated evaluation by github-manager-bot