Add default implementation for rejectRequest() in NettyRequestProcessor

[f1amingo]

Background

The rejectRequest() method in NettyRequestProcessor interface currently requires every implementation to provide its own override. However, 20+ implementations across the codebase simply return false, with only SendMessageProcessor and PullMessageProcessor containing actual logic.

Motivation

This boilerplate pattern creates unnecessary code duplication and increases the risk of forgetting to implement rejectRequest() when adding a new processor.

Proposed Change

Convert boolean rejectRequest() to default boolean rejectRequest() { return false; } in the interface, and remove all redundant return false overrides.

This is a zero-risk, pure cleanup change:

• Semantically equivalent (all removed overrides already return false)
• Existing overrides with real logic (Send/Pull) remain unaffected
• Compatible with Java 8+ (project target)

[RockteMQ-AI]

Issue Evaluation

Category: type/enhancement | Status: Evaluated — Confirmed Feasible

Verification against codebase:

Checked all 25 implementations of NettyRequestProcessor#rejectRequest() on the develop branch:

• 23 implementations simply return false (pure boilerplate)
• 2 implementations contain actual logic: SendMessageProcessor and PullMessageProcessor

The claim in this issue is accurate.

Feasibility: Feasible — zero-risk, pure cleanup
Scope: remoting/ (interface), broker/, client/, controller/, proxy/, container/, namesrv/ (implementations)
Compatibility: Fully backward compatible. Java 8+ supports default methods in interfaces. No behavioral change.

Assessment: This is a clean, well-scoped refactoring. Converting to default boolean rejectRequest() { return false; } and removing the 23 redundant overrides will reduce boilerplate without any semantic change. The two overrides with real logic remain untouched.

This change is straightforward and suitable for a first-time contributor or a quick cleanup PR.

---

Automated evaluation by github-manager