Skip to content

slf4j-api dependency may need specified in tools submodule pom #1073

@chnliyong

Description

@chnliyong

BUG REPORT

  1. Please describe the issue you observed:
  • What did you do (The steps to reproduce)?
mvn --projects tools --also-make clean  compile -U
  • What did you expect to see?
BUILD SUCCESS
  • What did you see instead?
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.5.1:compile (default-compile) on project rocketmq-tools: Compilation failure: Compilation failure:
[ERROR] /Users/<user>/workspace/rocketmq-all-4.4.0/tools/src/main/java/org/apache/rocketmq/tools/command/MQAdminStartup.java:[80,17] package org.slf4j does not exist
[ERROR] /Users/<user>/workspace/rocketmq-all-4.4.0/tools/src/main/java/org/apache/rocketmq/tools/command/MQAdminStartup.java:[208,44] cannot find symbol
[ERROR]   symbol:   variable LoggerFactory
[ERROR]   location: class org.apache.rocketmq.tools.command.MQAdminStartup
[ERROR] /Users/<user>/workspace/rocketmq-all-4.4.0/tools/src/main/java/org/apache/rocketmq/tools/command/MQAdminStartup.java:[211,11] cannot access org.slf4j.ILoggerFactory
[ERROR]   class file for org.slf4j.ILoggerFactory not found
[ERROR] -> [Help 1]
  1. Please tell us about your environment:

Codebase

rocketmq-all-4.4.0-source-release.zip
md5: 70d5e5cb933edf3e805bcbbc13f2e48a

OS

Darwin <hostname> 18.2.0 Darwin Kernel Version 18.2.0: Thu Dec 20 20:46:53 PST 2018; root:xnu-4903.241.1~1/RELEASE_X86_64 x86_64

JAVA VERSION

java version "1.8.0_201"
Java(TM) SE Runtime Environment (build 1.8.0_201-b09)
Java HotSpot(TM) 64-Bit Server VM (build 25.201-b09, mixed mode)

Maven version

Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-18T02:33:14+08:00)
Maven home: /usr/local/Cellar/maven/3.5.4/libexec
Java version: 1.8.0_201, vendor: Oracle Corporation, runtime: /Users/<user>/.sdkman/candidates/java/8.0.201-oracle/jre
Default locale: en_CN, platform encoding: UTF-8
OS name: "mac os x", version: "10.14.3", arch: "x86_64", family: "mac"
  1. Other information (e.g. detailed explanation, logs, related issues, suggestions how to fix, etc):

The rocketmq-tools's effective-pom shows that the org.slf4j:slf4-api:1.7.7 only in dependencyManagent(inherited from parent pom),not in dependencies,this dependency should explicit specified like the logging submodule

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions