[ISSUE #10114] Support delete consumer offset by consumer group and t…#10115
[ISSUE #10114] Support delete consumer offset by consumer group and t…#10115echooymxq wants to merge 1 commit intoapache:developfrom
Conversation
|
|
||
| RemotingCommand response = this.remotingClient.invokeSync(MixAll.brokerVIPChannel(this.clientConfig.isVipChannelEnabled(), addr), | ||
| request, timeoutMillis); | ||
| assert response != null; |
There was a problem hiding this comment.
Using assert to check for null values is not ideal. Users must add the JVM startup parameter -ea during configuration for it to take effect; otherwise, there is a risk of NPE errors.
There was a problem hiding this comment.
@Kris20030907 There are many similar issues in MQClientAPIImpl. We may need to open a separate issue for discussion.
There was a problem hiding this comment.
Yep, I think this is necessary; other projects have encountered similar issues in production environments.
cc.@RongtongJin
There was a problem hiding this comment.
@Kris20030907 From your perspective, i'd like to ask whether this features is necessary for users. we have encountered many users with similar demands in the production environment.
There was a problem hiding this comment.
This is just an optimization point. Without adding the -ea parameter, the assert logic here will not take effect. People who are unaware of this feature might be misled when troubleshooting, because IDEA automatically adds this parameter, which may differ from the actual environment.
There was a problem hiding this comment.
@Kris20030907 The feature I'm referring to specifically is delete consumer offset.😂
There was a problem hiding this comment.
got it, No users have raised this request yet, but I think it could be a good option.
Signed-off-by: sen <sen@example.com>
2 participants
Which Issue(s) This PR Fixes
Fixes #10114