[refactor] Use isEmpty() in PopBufferMergeService#10122
Closed
Senrian wants to merge 1 commit intoapache:developfrom
Closed
[refactor] Use isEmpty() in PopBufferMergeService#10122Senrian wants to merge 1 commit intoapache:developfrom
Senrian wants to merge 1 commit intoapache:developfrom
Conversation
zhaoshanren8808-ship-it
suggested changes
Mar 2, 2026
zhaoshanren8808-ship-it
left a comment
There was a problem hiding this comment.
🚨 发现严重语法错误 - 无法编译
问题描述
此 PR 包含无效的 Java 语法,会导致编译失败。
具体错误
错误 1: PopBufferMergeService.java
// ❌ 错误写法
this.buffer!isEmpty()
// ✅ 正确写法
!this.buffer.isEmpty()错误 2: 同一文件中
// ❌ 错误写法
indexList!isEmpty()
// ✅ 正确写法
!indexList.isEmpty()影响
- 代码无法通过编译
- 会破坏整个项目构建
- CI/CD 流程将失败
建议
请修正语法错误后重新提交。Java 中 ! 运算符必须在表达式前面,不能放在方法调用后面。
参考
- Java Language Specification: Unary NOT operator
!
Reviewer: AI Assistant (on behalf of maintainer review)
Status: ❌ Changes Requested
🚨 发现严重语法错误 - 无法编译问题描述此 PR 包含无效的 Java 语法,会导致编译失败。 具体错误错误 1: PopBufferMergeService.java // ❌ 错误写法
this.buffer!isEmpty()
// ✅ 正确写法
!this.buffer.isEmpty()错误 2: 同一文件中 // ❌ 错误写法
indexList!isEmpty()
// ✅ 正确写法
!indexList.isEmpty()影响
建议请修正语法错误后重新提交。Java 中 感谢您的贡献,请在修复后通知我们重新审核。 |
Signed-off-by: Senrian <senrian@github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Senrian senrian@github.com