Skip to content

[refactor] Use isEmpty() in PopBufferMergeService#10122

Closed
Senrian wants to merge 1 commit intoapache:developfrom
Senrian:pr2-isEmpty
Closed

[refactor] Use isEmpty() in PopBufferMergeService#10122
Senrian wants to merge 1 commit intoapache:developfrom
Senrian:pr2-isEmpty

Conversation

@Senrian
Copy link

@Senrian Senrian commented Mar 2, 2026

Signed-off-by: Senrian senrian@github.com

Copy link

@zhaoshanren8808-ship-it zhaoshanren8808-ship-it left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚨 发现严重语法错误 - 无法编译

问题描述

此 PR 包含无效的 Java 语法,会导致编译失败。

具体错误

错误 1: PopBufferMergeService.java

// ❌ 错误写法
this.buffer!isEmpty()

// ✅ 正确写法
!this.buffer.isEmpty()

错误 2: 同一文件中

// ❌ 错误写法
indexList!isEmpty()

// ✅ 正确写法
!indexList.isEmpty()

影响

  • 代码无法通过编译
  • 会破坏整个项目构建
  • CI/CD 流程将失败

建议

请修正语法错误后重新提交。Java 中 ! 运算符必须在表达式前面,不能放在方法调用后面。

参考

  • Java Language Specification: Unary NOT operator !

Reviewer: AI Assistant (on behalf of maintainer review)
Status: ❌ Changes Requested

@zhaoshanren8808-ship-it
Copy link

🚨 发现严重语法错误 - 无法编译

问题描述

此 PR 包含无效的 Java 语法,会导致编译失败。

具体错误

错误 1: PopBufferMergeService.java

// ❌ 错误写法
this.buffer!isEmpty()

// ✅ 正确写法
!this.buffer.isEmpty()

错误 2: 同一文件中

// ❌ 错误写法
indexList!isEmpty()

// ✅ 正确写法
!indexList.isEmpty()

影响

  • 代码无法通过编译
  • 会破坏整个项目构建
  • CI/CD 流程将失败

建议

请修正语法错误后重新提交。Java 中 ! 运算符必须在表达式前面,不能放在方法调用后面。


感谢您的贡献,请在修复后通知我们重新审核。

Signed-off-by: Senrian <senrian@github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants