Skip to content

[RIP-9] Update Feature.md#1020

Closed
Taxz wants to merge 3 commits intoapache:developfrom
Taxz:develop
Closed

[RIP-9] Update Feature.md#1020
Taxz wants to merge 3 commits intoapache:developfrom
Taxz:develop

Conversation

@Taxz
Copy link
Contributor

@Taxz Taxz commented Mar 3, 2019

What is the purpose of the change

Update Feature.md

Brief changelog

Modify some word tenses and page layouts

Verifying this change

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@Taxz Taxz changed the title [RIP-9] xxxx [RIP-9] Update Feature.md in rocketmq/docs/en Mar 3, 2019
@Taxz Taxz changed the title [RIP-9] Update Feature.md in rocketmq/docs/en [RIP-9] Update Feature.md Mar 3, 2019
Copy link
Contributor

@wlliqipeng wlliqipeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zongtanghu
Copy link
Contributor

It has conflicts.@Taxz Please resolve it in you local enviroment.

@Taxz Taxz closed this Mar 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants