[ISSUE #10247] Remove duplicate remove call in InvocationChannel#10359
Open
H145608 wants to merge 1 commit into
Open
[ISSUE #10247] Remove duplicate remove call in InvocationChannel#10359H145608 wants to merge 1 commit into
H145608 wants to merge 1 commit into
Conversation
Remove redundant second inFlightRequestMap.remove() call in writeAndFlush(). The remove was already called once at line 41 to retrieve the context. The duplicate remove at line 46 had no effect and was unnecessary. Fixes: apache#10247
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #10359 +/- ##
=============================================
- Coverage 48.97% 48.85% -0.12%
+ Complexity 13473 13437 -36
=============================================
Files 1375 1375
Lines 100452 100451 -1
Branches 12973 12973
=============================================
- Hits 49197 49078 -119
- Misses 45265 45365 +100
- Partials 5990 6008 +18 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove redundant second inFlightRequestMap.remove() call in writeAndFlush(). The remove was already called once at line 41 to retrieve the context. The duplicate remove at line 46 had no effect and was unnecessary.
Fixes: #10247
Which Issue(s) This PR Fixes
Brief Description
How Did You Test This Change?