Skip to content

Conversation

@RickySongyz
Copy link
Contributor

@RickySongyz RickySongyz commented Mar 9, 2019

What is the purpose of the change

Change "One consumequeue file consists of 30W entries, each entry can be randomly accessed like an array, each ConsumeQueue file's size is about 5.72M" to "One consumequeue file consists of 0.3 million entries, each entry can be randomly accessed like an array, each ConsumeQueue file's size is about 5.72MB"

Brief changelog

modified: docs/en/Design_Store.md

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

vongosling and others added 8 commits January 10, 2019 13:05
[RIP-9] Commit docs Example_OpenMessaging.md
… be randomly accessed like an array, each ConsumeQueue file's size is about 5.72M" to "One consumequeue file consists of 0.3 million entries, each entry can be randomly accessed like an array, each ConsumeQueue file's size is about 5.72MB"
@RickySongyz RickySongyz changed the title Change "One consumequeue file consists of 30W entries, each entry can be randomly accessed like an array, each ConsumeQueue file's size is about 5.72M" to "One consumequeue file consists of 0.3 million entries, each entry can be randomly accessed like an array, each ConsumeQueue file's size is about 5.72MB" [RIP-9]Change "One consumequeue file consists of 30W entries, each entry can be randomly accessed like an array, each ConsumeQueue file's size is about 5.72M" to "One consumequeue file consists of 0.3 million entries, each entry can be randomly accessed like an array, each ConsumeQueue file's size is about 5.72MB" Mar 9, 2019
@coveralls
Copy link

coveralls commented Mar 9, 2019

Coverage Status

Coverage increased (+0.1%) to 49.453% when pulling b6daf1b on RickySongyz:songyz-pr into 5134a8e on apache:develop.

@zongtanghu
Copy link
Contributor

@RickySongyz Please rebase your code in your local enviroment.

@zongtanghu zongtanghu changed the title [RIP-9]Change "One consumequeue file consists of 30W entries, each entry can be randomly accessed like an array, each ConsumeQueue file's size is about 5.72M" to "One consumequeue file consists of 0.3 million entries, each entry can be randomly accessed like an array, each ConsumeQueue file's size is about 5.72MB" [RIP-9]Change the "One consumequeue file content". Mar 9, 2019
@zongtanghu zongtanghu self-requested a review March 9, 2019 10:14
@zongtanghu zongtanghu added this to the 4.5.0 milestone Mar 9, 2019
@ShannonDing ShannonDing modified the milestones: 4.5.0, 4.6.0 Apr 10, 2019
@duhenglucky
Copy link
Contributor

@RickySongyz It would be nice if you can modify this PR as @zongtanghu @ShannonDing suggestion, and I will temporarily close this PR, and please feel free to reopen it if you want to do more work with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants