-
Notifications
You must be signed in to change notification settings - Fork 12k
[RIP-9]Change the "One consumequeue file content". #1068
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[RIP-9] Commit docs Example_OpenMessaging.md
… be randomly accessed like an array, each ConsumeQueue file's size is about 5.72M" to "One consumequeue file consists of 0.3 million entries, each entry can be randomly accessed like an array, each ConsumeQueue file's size is about 5.72MB"
Contributor
|
@RickySongyz Please rebase your code in your local enviroment. |
Contributor
|
@RickySongyz It would be nice if you can modify this PR as @zongtanghu @ShannonDing suggestion, and I will temporarily close this PR, and please feel free to reopen it if you want to do more work with it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Change "One consumequeue file consists of 30W entries, each entry can be randomly accessed like an array, each ConsumeQueue file's size is about 5.72M" to "One consumequeue file consists of 0.3 million entries, each entry can be randomly accessed like an array, each ConsumeQueue file's size is about 5.72MB"
Brief changelog
modified: docs/en/Design_Store.md
Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice,
it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.[ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyleto make sure basic checks pass. Runmvn clean install -DskipITsto make sure unit-test pass. Runmvn clean test-compile failsafe:integration-testto make sure integration-test pass.