[ROCKETMQ-204]-when all brokers is offline, client still attempts to send heartbeat #115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 similar comment
2 similar comments
Jaskey
changed the title
lizhanhui
reviewed
Jun 8, 2017
| } | ||
| } else { | ||
| Set<MessageQueue> prev = this.rebalanceImpl.getTopicSubscribeInfoTable().remove(topic); | ||
| log.info("instanceName={}, group={}, topicSubscribeInfoTable of topic {} is remove, {}, prev = {}", defaultMQPullConsumer.getInstanceName(), defaultMQPullConsumer.getConsumerGroup(), topic, prev); |
vsair
reviewed
Jun 9, 2017
| } | ||
| } else { | ||
| log.warn("updateTopicRouteInfoFromNameServer, getTopicRouteInfoFromNameServer return null, Topic: {}", topic); | ||
| log.warn("updateTopicRouteInfoFromNameServer, getTopicRouteInfoFromNameServer return null. Topic: {}", topic); |
Contributor
There was a problem hiding this comment.
IMO, API(getTopicRouteInfoFromNameServer) will throw exception when not found topic route, so the logic will never enter 'else', am I right?
Contributor
Author
There was a problem hiding this comment.
It seems you are right, this design is confusing , maybe we change the logic into returns null, Or I just catch the MQClientException for the same logic
I will suggest
- return null
- throw a prefine exception
which is closer to the presentative judgment .
Contributor
Author
|
@vsair @lizhanhui please review the updated pr |
Contributor
|
@Jaskey I'll check it today. |
Contributor
Author
|
any opinions? |
Member
|
@Jaskey I will close the pr, if you happened to the same question, please let me know. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://issues.apache.org/jira/browse/ROCKETMQ-204?jql=project%20%3D%20ROCKETMQ