Skip to content

Conversation

@mymailmjj
Copy link

@mymailmjj mymailmjj commented Apr 10, 2019

What is the purpose of the change

Some linux version do not support shell function keyword. I found this issue when I run fast-try.sh script on raspberrypi.
Folow is the command:
pi@raspberrypi:~/service/rocketmq/distribution/target/apache-rocketmq $ sh bin/dledger/fast-try.sh start
bin/dledger/fast-try.sh: 23: bin/dledger/fast-try.sh: Syntax error: "(" unexpected

Brief changelog

delete the function keyword,just left the function name

Verifying this change

I run the motified shell script on raspberrypi and centos 7,it works.

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@mymailmjj mymailmjj changed the title modify function synax to surpport more linux version modify shell function syntax to support more linux version Apr 10, 2019
@mymailmjj
Copy link
Author

Some linux version do not support shell function keyword. So I deleted the function keyword.

@coveralls
Copy link

coveralls commented Apr 10, 2019

Coverage Status

Coverage decreased (-0.08%) to 50.497% when pulling b382bfa on mymailmjj:master into 5f038c6 on apache:master.

@vongosling
Copy link
Member

vongosling commented Apr 12, 2019

ls -la /bin/sh

please use the command and tell us what output in your device:-)

@RongtongJin
Copy link
Contributor

@mymailmjj Thanks for submitting. You are right. However, the most important reason is that the default sh for Ubuntu/Debian is dash (the Debian Almquist Shell) rather than bash (the GNU Bourne-Again Shell), and dash does not support some syntax.

@vongosling vongosling changed the title modify shell function syntax to support more linux version Shell command compatibility problem Jul 27, 2019
@vongosling vongosling force-pushed the master branch 2 times, most recently from 247e0bf to ce4478a Compare October 12, 2019 06:44
@vongosling vongosling closed this May 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants