Skip to content

Conversation

@qqeasonchen
Copy link
Contributor

What is the purpose of the change
make RocketMQ to support to send batch message when change to DLedger mode

Brief changelog

We serialize the batch message to single message and add them to a list . Then Cyclicing get the message to use DLedgercommitlog append the message .
Implement the "putMessages(final MessageExtBatch messageExtBatch)" method
add the "serialize(final MessageExtBatch messageExtBatch)" method

Verifying this change

add an unit test to verifying the function and we test it in our testing environment

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

…R,CHARSET_UTF8

I miss  initialization value of NAME_VALUE_SEPARATOR,PROPERTY_SEPARATOR,CHARSET_UTF8  at last commit version . forgive me .
@duhenglucky duhenglucky requested a review from dongeforever July 18, 2019 03:21
@liuruiyiyang
Copy link
Contributor

please merge into develop branch.

@RongtongJin
Copy link
Contributor

@qqeasonchen Could you please close this PR? There is a same PR in the list.

@qqeasonchen qqeasonchen deleted the qqeasonchen-rocketmq-2 branch July 25, 2019 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants