Skip to content

[ISSUE #1336] Bug fix org.apache.rocketmq.store.DefaultMessageStore#g…#1338

Closed
ChaosYjh wants to merge 2 commits into
apache:developfrom
ChaosYjh:develop
Closed

[ISSUE #1336] Bug fix org.apache.rocketmq.store.DefaultMessageStore#g…#1338
ChaosYjh wants to merge 2 commits into
apache:developfrom
ChaosYjh:develop

Conversation

@ChaosYjh
Copy link
Copy Markdown
Contributor

Bug fix org.apache.rocketmq.store.DefaultMessageStore#getMessageIds return wrong result

What is the purpose of the change

Fix the bug in org.apache.rocketmq.store.DefaultMessageStore#getMessageIds line 1044

Brief changelog

set right position after get physical offset

Verifying this change

run test case in DefaultMessageStoreTest#testGetMessageIds

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@coveralls
Copy link
Copy Markdown

coveralls commented Jul 24, 2019

Coverage Status

Coverage remained the same at ?% when pulling 5a16c32 on ChaosYjh:develop into d71495a on apache:develop.

@xiangwangcheng
Copy link
Copy Markdown

LGTM.
@duhengforever @zongtanghu

@ChaosYjh
Copy link
Copy Markdown
Contributor Author

PTAL @duhenglucky @ShannonDing

#1336

@duhenglucky duhenglucky added this to the 4.6.0 milestone Oct 10, 2019
@vongosling vongosling closed this May 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants